loading...
Cover image for Hacktoberfest Completion Thread
The DEV Team

Hacktoberfest Completion Thread

thepracticaldev profile image dev.to staff ・1 min read

If you've completed Hacktoberfest 2020, this is your place to celebrate!!!

We'd all love to hear about your experience, see some of your PRs (hint: use the GitHub liquid tag!), and anything else related to Hacktoberfest that you'd like to share/show off.

You're also welcome to create a new post using the #hacktoberfest tag right here on DEV.

✨ CONGRATS! ✨

dancing pumpkin man

The DEV Team

The team behind this very platform. 😄

Discussion

pic
Editor guide
 

I did it so far!
3 PRs merges and really challenged to even do more :D

Just learned so much from people's feedback on the PRs and refactoring that.
Also felt like I needed to document better which pushed me.

My four contributions:

Added random boolean example script #21

Added boolean example page, also see this screenshot to see my tests.

This will solve issue #4

Screenshot 2020-10-01 at 16 52 26


Fix mobile issue #90

Issue that this pull request solves

Closes: #74

Proposed changes

Changed the footer to be center-aligned on Mobile. Added an alt text for the logo. Wrapped the logo in a P tag for space on mobile.

Types of changes

Put an x in the boxes that apply

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ x ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation update (Documentation content changed)
  • [ ] Other (please describe):

Checklist

Put an x in the boxes that apply

  • [ x ] My code follows the style guidelines of this project
  • [ x ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ x ] My changes generate no new warnings
  • [ x ] My changes does not break the current system and it passes all the current test cases.

Screenshots

Screenshot 2020-10-01 at 17 05 11

Other information

Any other information that is important to this pull request


Feature/multi tag #9

Fix issue #6 regarding the filters. You can now filter on multiple queries.

Please note: GitHub graph API does not like the "AND" filter, so included a custom filter (made a manual loop for speed)

You can see the result in the attached screenshot. It also still works for 1 query Screenshot 2020-10-02 at 10 13 30


Added random date + options and documentation #28

Hi,

Created the randomDate function which has the following formats:

  • min
  • max
  • format
  • range

Also added a documentation example that showcases different variants. Solves issue #26 Screenshot 2020-10-02 at 13 03 31

 

Hey @dailydevtips1 !
Thank you for your PR on rando-php project.
Your PR was high quality contributions (implementation, tests, documentation, examples).
I love hacktoberfest because we have the opportunity to meet people like you, improve the quality of the code, adding features, and learn a lot from each other!

Thank you!
Roberto

 

Indeed thank you for the opportunity I learned so much from that PR in terms of coding quality and documenting.
Also first touch on phpunit so very happy ✌️👌

 

Well, completed my first 4 pull requests on 01 October 2020 - like crack of dawn. Since then, did a few more. Hosting a newbie event this evening showing others how to do it.

 

Congrats!
Btw one of your pull request was created in my repo :)
Keep Contributing

 

Wow. Well, a humble thank for putting it together. I hope that next year I will be brave enough to create something like you did for other to do.

 

So pleased to knock this off in one night. Thanks to the superstar @techgirl007 for sharing your wisdom with us all. Thanks also to the team of helpers!

Happy #hacktoberfesting2020 to you all!

PS This is highly addictive. I will be back.

 

Congrats!
And Thanks for contributing in my repos.

 

Thanks for joining us and thanks to Digital Ocean, Dev and Git Hub for hosting this event. One small step forward can lead to amazing opportunities.

 

I was able to do it! Seem to be a lot more frontend devs compared to backend devs, so I've been able to help out with some Rails projects, updating pagination, helping write rspecs. Open source is fun

 

Just completed mine today 😀
All 4 PRs are merged and all are aligned with new Hacktoberfest 2020 rules.
Feeling excited 🤩
You can check here

 

I did it!!!!!!!!!!11 4PRs done and merged. Just getting reviewed.

Learned soo much about Git Hub. Glad to interact with you all.
Love from INDIA.

 

My PR submission is showing mature in 11 days. Shouldn't it be for 7 days?
dev-to-uploads.s3.amazonaws.com/i/...

 

They bumped up the PR maturity time to give maintainers more time to flag things as invalid/spam.

 

I created my 4 PR on 1st October. But my review period instead of extending by 1 week more 3rd October, has been reset. So 1st and 2nd October are not taken into account. Why is it so? Could you help

 

Completed hacktober now awaiting and even reviewed a lot of PRs after becoming maintainer for one repo

 

Almost there! #hacktoberfest
Looking to work on some more issues during the program

 

I did my four PRs and "completed" it!

.

.

.

Sadly they all in Ineligible Repository state even they are within information given in the rules and FAQ.

 
 

Got my first pull request! Hope it gets merged

 
 

I got my pr merged!! The other three are still in review! With this, I have entered the Open Source World! Thank you @dev @digitalOcean and everyone.

 

hey i submitted a pr for a repo that wasnt marked as hacktoberfest and it got merged will it count? its still in review period for me

 

hey! it depends on the time you submitted your PR
you can read more about it here
hacktoberfest.digitalocean.com/hac...

We will honor all valid pull requests prior to this change, and as of October 3, 2020 at 12:00:00 UTC – and October 3 in all time zones – pull requests will only count toward earning a T-shirt or planting a tree if they are submitted in a repository classified with the ‘hacktoberfest’ topic. The pull requests will also need to be merged, approved by a maintainer, or labeled as ‘hacktoberfest-accepted’ in order to qualify. The deadline for completions, merging, labeling, and approving is November 1.

hope this helps!